chore: Update Saas Service Management README to reference App Lifecycle Manager#12942
chore: Update Saas Service Management README to reference App Lifecycle Manager#12942
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the 'SaaS Runtime API' to 'App Lifecycle Manager' across the repository's metadata and README documentation. The review feedback identifies an inconsistency in the README's main header which still uses the old name and suggests using the singular 'API' in the authorization section for better consistency with other parts of the document.
| # Google SaaS Runtime API Client for Java | ||
|
|
||
| Java idiomatic client for [SaaS Runtime API][product-docs]. | ||
| Java idiomatic client for [App Lifecycle Manager][product-docs]. |
There was a problem hiding this comment.
The main header on line 1 (# Google SaaS Runtime API Client for Java) should also be updated to reference "App Lifecycle Manager" to maintain consistency throughout the document.
| ## Authorization | ||
|
|
||
| The client application making API calls must be granted [authorization scopes][auth-scopes] required for the desired SaaS Runtime API APIs, and the authenticated principal must have the [IAM role(s)][predefined-iam-roles] required to access GCP resources using the SaaS Runtime API API calls. | ||
| The client application making API calls must be granted [authorization scopes][auth-scopes] required for the desired App Lifecycle Manager APIs, and the authenticated principal must have the [IAM role(s)][predefined-iam-roles] required to access GCP resources using the App Lifecycle Manager API calls. |
There was a problem hiding this comment.
Consider using the singular "API" instead of "APIs" for consistency with the usage on line 76 and to better reflect the service name.
| The client application making API calls must be granted [authorization scopes][auth-scopes] required for the desired App Lifecycle Manager APIs, and the authenticated principal must have the [IAM role(s)][predefined-iam-roles] required to access GCP resources using the App Lifecycle Manager API calls. | |
| The client application making API calls must be granted [authorization scopes][auth-scopes] required for the desired App Lifecycle Manager API, and the authenticated principal must have the [IAM role(s)][predefined-iam-roles] required to access GCP resources using the App Lifecycle Manager API calls. |
| { | ||
| "api_shortname": "saasservicemgmt", | ||
| "name_pretty": "SaaS Runtime API", | ||
| "name_pretty": "App Lifecycle Manager", |
There was a problem hiding this comment.
This is generated from name_pretty in generation_config.yaml. Updating the config should trigger regeneration of this file and the README.
There was a problem hiding this comment.
Oh I see. repo-metadata is probably generated then
lqiu96
changed the title
3 participants
See b/505337310